Upgrade polkadot-sdk to db5e6454 (22 Jul 2025)
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade polkadot sdk - NoCurrency + other nits
dmitry-markin
changed the title
polkadot-sdkpolkadot-sdk to 161e7f4d (21 Jul 2025)
bkontur
approved these changes
Jul 22, 2025
Collaborator
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
@dmitry-markin looks good to me, left just couple of TODOs, which we do as follow-ups
Comment on lines
+49
to
50
| #[allow(deprecated)] | ||
| type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>; |
Collaborator
There was a problem hiding this comment.
we don't need this anymore - I had other PR yesterday and it works without RuntimeEvent
Suggested change
| #[allow(deprecated)] | |
| type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>; |
Contributor
Author
There was a problem hiding this comment.
I ran into weird issues with it removed — in the trait implementation neither removing the RuntimeEvent nor adding it compiles fine. Reverted for now.
Co-authored-by: Branislav Kontur <[email protected]>
NIts on upgrade polkadot sdk
bkontur
reviewed
Jul 22, 2025
dmitry-markin
changed the title
polkadot-sdk to 161e7f4d (21 Jul 2025)polkadot-sdk to db5e6454 (22 Jul 2025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
polkadot-sdkdependency. This pulls in among many other things:There are now deprecation warnings for using
SignedExtension(TransactionExtensionshould be used instead) — this is left for a follow-up.