Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

simplify kvdb error types#8924

Merged
andresilva merged 2 commits intomasterfrom
kvdb-error
Jul 2, 2018
Merged

simplify kvdb error types#8924
andresilva merged 2 commits intomasterfrom
kvdb-error

Conversation

@debris
Copy link
Collaborator

@debris debris commented Jun 19, 2018 •
edited
Loading

We never recover from database errors, so there is no need to have a special type for them. Let's keep it simple and use io::Error instead

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jun 19, 2018
@5chdn 5chdn added this to the 1.12 milestone Jun 20, 2018
@andresilva
Copy link
Contributor

andresilva commented Jun 22, 2018

Please rebase or merge master.

@debris
Copy link
Collaborator Author

debris commented Jun 28, 2018

rebased

ascjones
ascjones approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 2, 2018
@andresilva andresilva merged commit 5ef41ed into master Jul 2, 2018
@5chdn 5chdn deleted the kvdb-error branch July 2, 2018 09:52
dvdplm added a commit that referenced this pull request Jul 2, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
afbf3a9 
* master:
  Attempt to graceful shutdown in case of panics (#8999)
  simplify kvdb error types (#8924)
  Add option for user to set max size limit for RPC requests (#9010)
  bump ntp to 0.5.0 (#9009)
  Removed duplicate dependency (#9021)
ordian added a commit to ordian/parity that referenced this pull request Jul 9, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
2f27219 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Attempt to graceful shutdown in case of panics (openethereum#8999)
  simplify kvdb error types (openethereum#8924)
  Add option for user to set max size limit for RPC requests (openethereum#9010)
  bump ntp to 0.5.0 (openethereum#9009)
  Removed duplicate dependency (openethereum#9021)
  Minimal effective gas price in the queue (openethereum#8934)
@dvdplm dvdplm mentioned this pull request Aug 6, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ascjones ascjones ascjones approved these changes

@andresilva andresilva andresilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.

Projects

None yet

Milestone

2.0 Ethereum

Development

Successfully merging this pull request may close these issues.

4 participants

@debris @andresilva @ascjones @5chdn