This repository was archived by the owner on Nov 6, 2020. It is now read-only.
[spec] fix rinkeby spec#11108
Merged
Merged
Conversation
ordian
added
A0-pleasereview 🤓
niklasad1
added
A8-looksgood 🦄
Collaborator
|
Ah... while I was working on the json-tests I actually noticed that we had this odd 1wei balance for the builtins. Apparently this is the workaround we used years back when we had a consensus issue with geth and the ripemd bultin contract was removed due to it being considered empty. Sending 1wei to the builtins made them non-empty and so they were not removed... |
dvdplm
approved these changes
Oct 1, 2019
dvdplm
added
A7-looksgoodtestsfail 🤖
niklasad1
added
A8-looksgood 🦄
niklasad1
pushed a commit
that referenced
this pull request
Oct 2, 2019
niklasad1
pushed a commit
that referenced
this pull request
Oct 2, 2019
ordian
pushed a commit
that referenced
this pull request
Oct 2, 2019
ordian
pushed a commit
that referenced
this pull request
Oct 2, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused genesis hash mismatch.