From 7fb1f6866f5d0083451c97ac3c71b9533c954f1f Mon Sep 17 00:00:00 2001 From: echo Date: Thu, 5 May 2022 20:12:15 +0800 Subject: [PATCH 1/2] Small opt when prune messages --- modules/messages/src/outbound_lane.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/messages/src/outbound_lane.rs b/modules/messages/src/outbound_lane.rs index e4566b8895..2660a89e03 100644 --- a/modules/messages/src/outbound_lane.rs +++ b/modules/messages/src/outbound_lane.rs @@ -148,19 +148,17 @@ impl OutboundLane { /// Returns number of pruned messages. pub fn prune_messages(&mut self, max_messages_to_prune: MessageNonce) -> MessageNonce { let mut pruned_messages = 0; - let mut anything_changed = false; let mut data = self.storage.data(); while pruned_messages < max_messages_to_prune && data.oldest_unpruned_nonce <= data.latest_received_nonce { self.storage.remove_message(&data.oldest_unpruned_nonce); - anything_changed = true; pruned_messages += 1; data.oldest_unpruned_nonce += 1; } - if anything_changed { + if prune_messages > 0 { self.storage.set_data(data); } From 630c0364fd48f47950fa07351a6c59b08d591ba0 Mon Sep 17 00:00:00 2001 From: echo Date: Thu, 5 May 2022 20:23:56 +0800 Subject: [PATCH 2/2] Fix typing error --- modules/messages/src/outbound_lane.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/messages/src/outbound_lane.rs b/modules/messages/src/outbound_lane.rs index 2660a89e03..041dec214b 100644 --- a/modules/messages/src/outbound_lane.rs +++ b/modules/messages/src/outbound_lane.rs @@ -158,7 +158,7 @@ impl OutboundLane { data.oldest_unpruned_nonce += 1; } - if prune_messages > 0 { + if pruned_messages > 0 { self.storage.set_data(data); }