Skip to content

Fix Bitswap protocol implementation #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-markin merged 3 commits into from
Jun 25, 2025
Merged

Fix Bitswap protocol implementation #402

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
935ee56
Fix Bitswap protocol implementation
dmitry-markin Jun 24, 2025
a4a1952
minor: make clippy happy
dmitry-markin Jun 24, 2025
f4c9a7e
minor: simplify a bit with `Default::default()`
dmitry-markin Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/protocol/libp2p/bitswap/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,15 @@ impl Bitswap {
return;
};

let mut response = schema::bitswap::Message::default();
let mut response = schema::bitswap::Message {
// `Wantlist` field must always be present. This is what the official Kubo IPFS
// implementation does.
wantlist: Some(schema::bitswap::Wantlist {
entries: Vec::new(),
full: false,
}),
..Default::default()
};

for entry in entries {
match entry {
Expand Down Expand Up @@ -205,6 +213,8 @@ impl Bitswap {

let message = response.encode_to_vec().into();
let _ = tokio::time::timeout(WRITE_TIMEOUT, substream.send_framed(message)).await;

substream.close().await;
}

/// Handle bitswap response.
Expand Down
Loading