Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multisig example #962

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Improve multisig example #962

merged 4 commits into from
Oct 15, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Oct 15, 2021

This PR contains two things:

  • Rename multisig_plain to just multisig.
  • Allow transactions which are submitted and evaluated via eval_transaction to be payable. This is something we fixed a while ago for invoke_transaction, but apparently forgot for the eval function. I'll add an ink-waterfall test for eval_transaction with a payable transaction as a follow-up.

Robbepop
Robbepop approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmichi cmichi merged commit 44951c9 into master Oct 15, 2021
@cmichi cmichi deleted the cmichi-enable-payable-transactions-to-be-evaluated branch October 15, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @Robbepop