Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new seal_random API #734

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Add support for new seal_random API #734

merged 2 commits into from
Mar 19, 2021

Conversation

athei
Copy link
Contributor

@athei athei commented Mar 15, 2021

This adds support for the new seal_random API which will be added by paritytech/substrate#8329 .

It is guarded behind a feature flag to allow supporting older chain versions which do not support the new API.

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good to me. Thanks for the PR!

crates/env/Cargo.toml Outdated Show resolved Hide resolved
@athei
Copy link
Contributor Author

athei commented Mar 19, 2021

I removed the feature.

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot @athei !

@Robbepop Robbepop merged commit 513cb76 into master Mar 19, 2021
@Robbepop Robbepop deleted the at-new-random branch March 19, 2021 14:16
@athei
Copy link
Contributor Author

athei commented Mar 22, 2021

Maybe you can slap a review on the linked PR so we get the feature merged to the contracts pallet, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants