Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] change node url backend config #2101

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Feb 7, 2024

Modifies the e2e configuration for backend node from node_url = "<url>" to backend(node(url = "<url>")).

The previous configuration allowed node_url to be set even if using backend(runtime_only) which uses no node at all so the url is not used at all.

Follows up #2047

@SkymanOne
Copy link
Contributor

Maybe we can make the url an optional param?

- backend(node(url = "<URL>"))
+ backend(node = "<URL>")

@ascjones
Copy link
Collaborator Author

ascjones commented Feb 7, 2024

Maybe we can make the url an optional param?

- backend(node(url = "<URL>"))
+ backend(node = "<URL>")

I'm not sure exactly how to achieve that using Darling. Would have to make node a property of Backend, but that is an enum not a struct hence the derive produces the enum(variant) syntax.

I've played around a little bit and can't immediately find a nice way to do that. I'm sure it is possible but I will leave it for now.

@SkymanOne
Copy link
Contributor

Maybe we can make the url an optional param?

- backend(node(url = "<URL>"))
+ backend(node = "<URL>")

I'm not sure exactly how to achieve that using Darling. Would have to make node a property of Backend, but that is an enum not a struct hence the derive produces the enum(variant) syntax.

I've played around a little bit and can't immediately find a nice way to do that. I'm sure it is possible but I will leave it for now.

It is not critical ofc, just nice to have less verbose syntax

@ascjones ascjones merged commit fc51ea7 into master Feb 8, 2024
22 of 23 checks passed
@ascjones ascjones deleted the aj/e2e-runtime-only-node-url branch February 8, 2024 11:37
@SkymanOne SkymanOne mentioned this pull request Feb 8, 2024
@SkymanOne SkymanOne mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants