Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non_camel_case_types for EventBase ident #1107

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

HCastano
Copy link
Contributor

Small PR to stop rust-analyzer from complaining when it expands the macros in the
example contracts.

@Robbepop
Copy link
Collaborator

Small PR to stop rust-analyzer from complaining when it expands the macros in the
example contracts.

Maybe instead we could just generate proper type names? ^^

@HCastano
Copy link
Contributor Author

Small PR to stop rust-analyzer from complaining when it expands the macros in the
example contracts.

Maybe instead we could just generate proper type names? ^^

Basically all of the internal codegen types are already using this convention (and their warnings are being suppressed in the same way).

I'd be happy to change these types to follow Rust convention in a follow up, but I don't really want to do that today tbh.

@codecov-commenter
Copy link

Codecov Report

Merging #1107 (fbe88f8) into master (c5fe47b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files         252      252           
  Lines        9397     9397           
=======================================
  Hits         7409     7409           
  Misses       1988     1988           
Impacted Files Coverage Δ
crates/lang/codegen/src/generator/events.rs 97.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5fe47b...fbe88f8. Read the comment docs.

@HCastano
Copy link
Contributor Author

(Gonna merge, but as I mentioned to Robin I'll follow up with a proper fix)

@HCastano HCastano merged commit 2785a90 into master Jan 26, 2022
@HCastano HCastano deleted the hc-non-camel-case-types-for-base-event-ident branch January 26, 2022 03:28
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants