Name API consistently: transferred_balance ➔ transferred_value
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Wed Dec 1 20:34:38 CET 2021 |
Codecov Report
@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
- Coverage 78.74% 75.35% -3.39%
==========================================
Files 248 248
Lines 9371 9369 -2
==========================================
- Hits 7379 7060 -319
- Misses 1992 2309 +317
Continue to review full report at Codecov.
|
☝️ 💯 |
ascjones
approved these changes
Dec 2, 2021
| @@ -357,7 +357,7 @@ impl TypedEnvBackend for EnvInstance { | |||
| self.get_property_inplace::<T::AccountId>(ext::caller) | |||
| } | |||
|
|
|||
| fn transferred_balance<T: Environment>(&mut self) -> T::Balance { | |||
| fn transferred_value<T: Environment>(&mut self) -> T::Balance { | |||
There was a problem hiding this comment.
If we really wanted to nitpick on the consistency then the seal fn value_transferred should also be the same 😀
xgreenx
pushed a commit
to Supercolony-net/ink
that referenced
this pull request
Feb 8, 2022
…se-ink#1063) * Name API consistently: `transferred_balance` ➔ `transferred_value` * Apply `cargo fmt`
freespirit
added a commit
to freespirit/ink-docs
that referenced
this pull request
Jul 22, 2023
transferred_balance was renamed to transferred_value in use-ink/ink#1063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I honestly don't care what we rename it to, but we should finally make the naming consistent.
I'm not opening up the whole thing with renaming endowment to value that was started in paritytech/substrate#10082 here.