Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty-print call dry-run return data #967

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Pretty-print call dry-run return data #967

merged 1 commit into from
Feb 13, 2023

Conversation

ascjones
Copy link
Collaborator

Regression introduced in #722 where it uses the Debug output for the returned dry-run value, instead of the Display. See before and after:

image

cmichi
cmichi approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone at the workshop actually ran into this! Thanks for fixing!

@ascjones ascjones merged commit 0eebc11 into master Feb 13, 2023
@ascjones ascjones deleted the aj/dry-run-return-value-display branch February 13, 2023 11:08
@ascjones ascjones mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi approved these changes

@HCastano HCastano Awaiting requested review from HCastano

@SkymanOne SkymanOne Awaiting requested review from SkymanOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascjones @cmichi