Require env_type transcoders to be Send + Sync #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are already required to be 'static, so this seems like a reasonable requirement. In practice, it seems only `AccountId` and `Hash` transcoders are inserted into this collection. Adding these two traits allows a `ContractMetadataTranscoder` to be shared between threads via an `Arc`. This is very useful, especially given a `ContractMetadataTranscoder` is not even `Clone`, which makes it unwieldy to load the metadata once and use it around the program.
obrok
force-pushed
the
send-sync-env-types
branch
from
06a7a1f
to
c0ade59
Compare
ascjones
reviewed
Jan 3, 2023
crates/transcode/src/env_types.rs
Outdated
| @@ -45,15 +45,15 @@ use std::{ | |||
| /// Provides custom encoding and decoding for predefined environment types. | |||
| #[derive(Default)] | |||
| pub struct EnvTypesTranscoder { | |||
| encoders: HashMap<u32, Box<dyn CustomTypeEncoder>>, | |||
| decoders: HashMap<u32, Box<dyn CustomTypeDecoder>>, | |||
| encoders: HashMap<u32, Box<dyn CustomTypeEncoder + Send + Sync>>, | |||
There was a problem hiding this comment.
Would it also work if we added those constraints to the trait itself e.g. CustomTyoeEncoder: Send + Sync?
There was a problem hiding this comment.
Yeah, that works as well, updated the PR.
ascjones
approved these changes
Jan 5, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are already required to be
'static, so this seems like a reasonable requirement. In practice, it seems onlyAccountIdandHashtranscoders are inserted into this collection. Adding these two traits allows aContractMetadataTranscoderto be shared between threads via anArc. This is very useful, especially given aContractMetadataTranscoderis not evenClone, which makes it unwieldy to load the metadata once and use it around the program.