Add support for ink!'s version metadata field
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI looks unnecessarily upset with some things 😅 I'll fix them tomorrow |
|
@cmichi it looks like the estuary job runs with |
|
The estuary job can't pass until we stop using Git dependencies for the ink! dependencies (can't publish a crate that includes ink! dependencies). |
There's only one metadata version that can be constructed, so the check doesn't totally make sense. In the future if we support both V4 and V5 metadata formats it would make sense to add such a check back.
ascjones
reviewed
Aug 24, 2022
transcode/README.md
Outdated
|
|
||
| if let ink_metadata::MetadataVersioned::V3(ink_project) = ink_metadata { | ||
| Ok(ink_project) | ||
| let ink_metadata: ink_metadata::InkProject = serde_json::from_value( |
There was a problem hiding this comment.
Nice that you fixed this example in the README, however it is quite brittle for the code to be here in the first place. See #705
There's only one metadata version that can be constructed, so the check doesn't totally make sense. In the future if we support both V4 and V5 metadata formats it would make sense to add such a check back.
cmichi
approved these changes
Aug 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ink! PR: use-ink/ink#1313.
This can't be merged until the ink! PR is merged.
We may also want to replace the Git references with a
patchto a4.0pre-releasebranch or something.
(Sorry about the formatting changes btw, looks like some of these files pre-date our useI was on a different nightly, so my theory was wrong hereof RustFmt)