Attempt at installing accountid20#1183
Closed
JoshOrndorff wants to merge 2 commits into
Closed
Conversation
JoshOrndorff
requested review from
HCastano,
SkymanOne,
ascjones and
cmichi
as code owners
Author
|
I'm closing this in favor of #1186 . I've made a much better attempt over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the beginning of an attempt to generalize the accountid type. Substrate itself supports being generic over the accountid, but cargo contract assumes it to be
AccountId20.One confusion I had is why the
AccountId20type is duplicated in this repo. I understood that subxt duplicated it so it doesn't have to depend on sp-core. But why duplicate it again here?Any advice or help in this effort is much appreciated.
This attempts to solve #1182