Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: fee estimation #833

Merged
merged 11 commits into from
Apr 4, 2023
Merged

fix: fee estimation #833

merged 11 commits into from
Apr 4, 2023

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented Mar 31, 2023 •
edited by tjjfvi
Loading

Resolves #830

@ryanleecode ryanleecode marked this pull request as ready for review March 31, 2023 14:46
@ryanleecode ryanleecode changed the title chore: update feat estimate api chore: update fee estimate api Mar 31, 2023
harrysolovay
harrysolovay suggested changes Mar 31, 2023
View reviewed changes
fluent/ExtrinsicRune.ts Outdated Show resolved Hide resolved
fluent/ExtrinsicRune.ts Outdated Show resolved Hide resolved
fluent/ExtrinsicRune.ts Outdated Show resolved Hide resolved
@harrysolovay harrysolovay force-pushed the chore/update-feat-estimate-api branch from 1984128 to 4d3ed09 Compare March 31, 2023 17:16
@ryanleecode
Copy link
Contributor Author

ryanleecode commented Mar 31, 2023 •
edited
Loading

It now works. before wasn't working because the codec wasn't using compact for u64 types

@harrysolovay harrysolovay changed the title chore: update fee estimate api fix: fee estimation Mar 31, 2023
tjjfvi
tjjfvi reviewed Apr 4, 2023
View reviewed changes
fluent/ExtrinsicRune.ts Outdated Show resolved Hide resolved
tjjfvi
tjjfvi previously approved these changes Apr 4, 2023
View reviewed changes
@harrysolovay harrysolovay enabled auto-merge April 4, 2023 15:05
harrysolovay
harrysolovay previously approved these changes Apr 4, 2023
View reviewed changes
@harrysolovay harrysolovay added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@harrysolovay harrysolovay added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@harrysolovay harrysolovay added this pull request to the merge queue Apr 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023
@harrysolovay harrysolovay dismissed stale reviews from tjjfvi and themself via 0b6dcc5 April 4, 2023 17:10
@harrysolovay harrysolovay force-pushed the chore/update-feat-estimate-api branch from 0e6354a to 0b6dcc5 Compare April 4, 2023 17:10
@harrysolovay harrysolovay enabled auto-merge April 4, 2023 17:14
@harrysolovay harrysolovay added this pull request to the merge queue Apr 4, 2023
Merged via the queue into main with commit 14b6dbb Apr 4, 2023
@harrysolovay harrysolovay deleted the chore/update-feat-estimate-api branch April 4, 2023 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjjfvi tjjfvi tjjfvi approved these changes

@harrysolovay harrysolovay harrysolovay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revert #829
3 participants
@ryanleecode @harrysolovay @tjjfvi