-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
4: 1, | ||
8: 1, | ||
32: 2, | ||
33: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These libs support 33 byte
payload with 2 byte
checksum
It would be |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a test for every valid address length and every valid payload length to make sure they always round-trip correctly?
I could add decoding tests for the 16 formats. |
9a91a9b
to
ccd29ed
Compare
0bfd44d
to
3fe6178
Compare
f097dca
to
b9aa433
Compare
Resolves #619
Add ss58 encoding and decoding for different payload and checksum lengths (see ss58-format).
Note:
MultiAdress.Index
use formats whose checksum length is1
provided that the index is of typeu8
,u16
,u32
oru64
(1
,2
,4
or8
byte payload).