Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: star task #701

Merged
merged 3 commits into from
Mar 3, 2023
Merged

fix: star task #701

merged 3 commits into from
Mar 3, 2023

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Mar 3, 2023

Revert a bad copy/paste from #666 and add extra logs for error debugging

@@ -76,10 +76,14 @@ for (const [file, deps] of entries.slice(1)) {
if (done.has(file)) continue
console.log(file)
const command = new Deno.Command(Deno.execPath(), {
args: ["info", "-r=http://localhost:4646/", "--json", "target/star.ts"],
args: ["cache", "--check", file],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad copy paste from #666

@kratico kratico marked this pull request as ready for review March 3, 2023 17:16
@tjjfvi
Copy link
Contributor

tjjfvi commented Mar 3, 2023

🎉 Woo, there are type errors! 🎉

(never thought I'd say that)

@harrysolovay
Copy link
Contributor

The type errors have to do with #695 –– EventsRune doesn't have a map method, hence we need to convert to ValueRune in various places. Pushing the fix here soon.

@harrysolovay harrysolovay merged commit 84d5702 into main Mar 3, 2023
@harrysolovay harrysolovay deleted the fix/star-task branch March 3, 2023 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants