-
Notifications
You must be signed in to change notification settings - Fork 9
fix: process resource cleanup in start task #648
Conversation
1e11cac
to
45c0e9e
Compare
@@ -96,7 +96,10 @@ export class ZombienetProvider extends FrameProxyProvider { | |||
}) | |||
let closeProcess = () => { | |||
closeProcess = () => {} | |||
process.kill() | |||
console.log("closing zombienet rid:", process.rid) | |||
process.kill("SIGINT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's actually hold off on merging this, as we will likely want to capture dev process std out for signaling boot progress #649
@harrysolovay Would it be for boot progress or error debugging? |
Both. I suppose we can tackle that in a subsequent PR. This looks good. |
This reverts commit 230b80c.
045c683
to
4698e78
Compare
Based on trial and error, it seems that sometimes
zombienet
Deno resources are not properly released.I haven't been able to identify the root cause.
The
unload
event is not fired in these cases.This PR
Deno.run
piped
file descriptorsNote: I've observed that the
star
task sometimes keeps running even after closing fd and processesAnother theory to explore is that this could be correlated to a recent Deno version upgrade.
This is related to #625