Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

docs: running examples in node #1157

Merged
merged 7 commits into from
Jul 11, 2023
Merged

docs: running examples in node #1157

merged 7 commits into from
Jul 11, 2023

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented Jul 10, 2023

Adds to the readme instructions on how to batch run all examples with deno and node.

@ryanleecode ryanleecode marked this pull request as ready for review July 10, 2023 16:45
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the readme in examples/?

Readme.md Outdated Show resolved Hide resolved
@ryanleecode
Copy link
Contributor Author

Do we rlly need a readme in the examples folder if its just copy and paste?

@harrysolovay
Copy link
Contributor

Is this needed?

Or, to run them all[...]

^ kind of runs them all... but any non-error logs aren't visible. Not sure we need docs on this.

@ryanleecode
Copy link
Contributor Author

this should work better

@ryanleecode ryanleecode changed the title docs: running examples in deno and node docs: running examples in node Jul 10, 2023
@tjjfvi
Copy link
Contributor

tjjfvi commented Jul 10, 2023

Do we rlly need a readme in the examples folder if its just copy and paste?

Not really, it should probably just be deleted

@harrysolovay harrysolovay added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 3722265 Jul 11, 2023
@harrysolovay harrysolovay deleted the docs/example-testing branch July 11, 2023 15:53
harrysolovay pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants