This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
fix: add optional field handling to pjs compat #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Ah, good catch. Yeah, this should work.
this fixes the problem, though I'm not sure if a similar handler should also be added to
https://github.com/paritytech/capi/blob/main/patterns/compat/pjs_sender.ts#L62
and
https://github.com/paritytech/capi/blob/main/patterns/compat/pjs_sender.ts#L75
No need – these objects are custom (derived from the metadata, but not directly represented in it), and it's not written to generate optional fields.
tjjfvi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #1105
unfortunately the nft collection creation still wasn't working on gamma 1 of capi
code was breaking on assetId field, which is part of ChargeAssetTxPayment
this fixes the problem, though I'm not sure if a similar handler should also be added to
https://github.com/paritytech/capi/blob/main/patterns/compat/pjs_sender.ts#L62
and
https://github.com/paritytech/capi/blob/main/patterns/compat/pjs_sender.ts#L75