Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

setup binary does not exit with status code 0 if the binary url returns a 404 #530

Closed
ryanleecode opened this issue Jan 27, 2023 · 0 comments · Fixed by #531
Closed

setup binary does not exit with status code 0 if the binary url returns a 404 #530

ryanleecode opened this issue Jan 27, 2023 · 0 comments · Fixed by #531
Labels
bug Something is broken

Comments

@ryanleecode
Copy link
Contributor

curl needs to have a --fail flag otherwise it will just output a file with

Not Found

as its contents.
@ryanleecode ryanleecode added the bug Something is broken label Jan 27, 2023
@ryanleecode ryanleecode changed the title setup binary does not exit with status code 1 if the binary url returns a 404 setup binary does not exit with status code 0 if the binary url returns a 404 Jan 27, 2023
@ryanleecode ryanleecode mentioned this issue Jan 27, 2023
Merged
@github-project-automation github-project-automation bot moved this to Properly Done in Capi Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something is broken
Projects
Capi
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: download binary not having --fail flag paritytech/capi
1 participant
@ryanleecode