Remove decl_collector pass and use SWC's unresolved_mark instead #9520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decl_collector pass stored all declarations in a HashSet so we could determine if a variable is a global (i.e. undeclared). This is used to find
require
calls and much more. Turns out we don't really need this anymore because SWC has anunresolved_mark
that it sets on these identifiers in its resolver. Removing this saves us a pass, reduces some memory usage, and simplifies the code by reducing the number of places we need to keep up to date.