Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ascii_only for swc emit #9243

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Set ascii_only for swc emit #9243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06f4dcc
Set ascii_only for swc emit
mischnic Sep 13, 2023
c4f1ce1
Add comments
mischnic Sep 16, 2023
8579b1d
Merge branch 'v2' into emit-ascii-only
mischnic Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/core/integration-tests/test/javascript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6365,6 +6365,27 @@ describe('javascript', function () {
assert.deepEqual(output.default, {color: 'blue'});
});

it('should retain unicode escape sequences', async function () {
mischnic marked this conversation as resolved.
Show resolved Hide resolved
// See issue #8877
await fsFixture(overlayFS, __dirname)`
src/index.js:
export default ['\\u0085', '\\u200b', '\\ufffe'];
`;

let b = await bundle(path.join(__dirname, 'src/index.js'), {
inputFS: overlayFS,
});

let output = (await run(b)).default;
assert.deepEqual(output, ['\u0085', '\u200b', '\ufffe']);

let contents = await outputFS.readFile(b.getBundles()[0].filePath, 'utf8');
assert.equal(contents.match(/\\/g).length, 3);
assert(!contents.includes('\u0085'));
assert(!contents.includes('\u200b'));
assert(!contents.includes('\ufffe'));
});

for (let shouldScopeHoist of [false, true]) {
let options = {
defaultTargetOptions: {
Expand Down
6 changes: 4 additions & 2 deletions packages/transformers/js/core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,10 @@ fn emit(
None
},
));
let config =
swc_core::ecma::codegen::Config::default().with_target(swc_core::ecma::ast::EsVersion::Es5);
let config = swc_core::ecma::codegen::Config::default()
.with_target(swc_core::ecma::ast::EsVersion::Es5)
// Make sure the output works regardless of whether it's loaded with the correct (utf8) encoding
.with_ascii_only(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also affect pre-existing unicode characters? E.g. does it turn '🙂' into '\uD83D\uDE42'?

Copy link
Member Author

@mischnic mischnic Sep 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. So I think we shouldn't actually do this.

This leads to the question: if Chrome allows 🙂, then why does it not allow some other unicode that is probably equally valid? (Unless it isn't valid which is what I asked about here)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed in 2.7 that caused this issue in the first place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a swc upgrade.
Input: ["\u0085", "\u200b", "\ufffe", "🙂"];
With 2.6.2: ["\x85", "\u200B", "\uFFFE", "\uD83D\uDE42"]
With 2.7.0: ["\x85", "​", "�", "\uD83D\uDE42"]
With 2.9.0: ["\x85", "​", "�", "\uD83D\uDE42"]

So your concern is already the case, it just doesn't happen for single-codepoint characters (or something like that)

does it turn '🙂' into '\uD83D\uDE42'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yeah, this PR would restore the behavior from 2.6.2, which is perfectly fine to me and hasn't bothered anyone since.

let mut emitter = swc_core::ecma::codegen::Emitter {
cfg: config,
comments: Some(&comments),
Expand Down
Loading