Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/devDeps: unpin fast-glob #8996

Merged
merged 1 commit into from
May 10, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 9, 2023

↪️ Pull Request

This was originally held back in #4265 (a07a8b8).

The upstream issue has since been resolved. This dedupes fast-glob@3.*.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@legobeat legobeat marked this pull request as ready for review May 9, 2023 04:46
This was originally held back in parcel-bundler#4265 (a07a8b8).

The upstream issue has since been resolved. This dedupes fast-glob@3.*.
Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devongovett Any concerns because you originally pinned the version?

@devongovett
Copy link
Member

I guess it was due to some bugs: #4265. Looks like both are fixed now.

@devongovett devongovett merged commit f7174f6 into parcel-bundler:v2 May 10, 2023
@legobeat legobeat deleted the chore-unpin-fast-glob branch September 4, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants