Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust wasm-gc test #862

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

mvlabat
Copy link
Contributor

@mvlabat mvlabat commented Feb 20, 2018

Make the build green again :)

Why the test was red: with Rust 1.24 bundle size got larger for some reason, but it was still reasonably small (295 bytes vs 17961 bytes). I thought.. why don't we just compare not minified bundle against the minified one?

@codecov-io
Copy link

Codecov Report

Merging #862 into master will increase coverage by 5.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   85.65%   91.63%   +5.97%     
==========================================
  Files          57       68      +11     
  Lines        1973     3311    +1338     
==========================================
+ Hits         1690     3034    +1344     
+ Misses        283      277       -6
Impacted Files Coverage Δ
src/utils/installPackage.js 91.11% <0%> (-4.55%) ⬇️
src/utils/serializeObject.js 88.23% <0%> (-3.44%) ⬇️
src/assets/HTMLAsset.js 96.66% <0%> (-2.23%) ⬇️
src/transforms/postcss.js 93.18% <0%> (-1.56%) ⬇️
src/packagers/index.js 92.3% <0%> (-1.45%) ⬇️
src/assets/JSONAsset.js 92.3% <0%> (-1.45%) ⬇️
src/utils/getTargetEngines.js 98.73% <0%> (-1.27%) ⬇️
src/visitors/globals.js 96.15% <0%> (-0.91%) ⬇️
src/assets/TypeScriptAsset.js 100% <0%> (ø) ⬆️
src/assets/YAMLAsset.js 100% <0%> (ø) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafb6ef...c13a835. Read the comment docs.

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🏆

@devongovett devongovett merged commit 0d9d14c into parcel-bundler:master Feb 20, 2018
DeMoorJasper pushed a commit that referenced this pull request Feb 20, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants