Fix CommonJS symbol collection without scope hoisting #8555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue building the React Spectrum docs website with the latest version of parcel, which appears to have been introduced by #7991. We have a weird setup that disables scope hoisting in production builds for "server" bundles, but symbol propagation still runs. The linked PR changed some things regarding how dependencies are tracked, and the non-scope hoisting case didn't correctly handle non ESM. This led to an asset being omitted as unused. Unfortunately, I didn't manage to produce a smaller reproduction, but this code mirrors the logic in the scope hoisting case, and does fix the issue.