Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Flow 0.158 #6763

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Upgrade to Flow 0.158 #6763

merged 2 commits into from
Aug 29, 2021

Conversation

mischnic
Copy link
Member

Private methods are now properly supported

@height
Copy link

height bot commented Aug 25, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic changed the title Upgrade to Flow 158 Upgrade to Flow 0.158 Aug 25, 2021
@parcel-benchmark
Copy link

parcel-benchmark commented Aug 25, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.11s -75.00ms
Cached 328.00ms +12.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 685.00ms +37.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 684.00ms +36.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 756.00ms +105.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 757.00ms +105.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 757.00ms +106.00ms ⚠️
dist/modern/index.65a4b415.js 1.08kb +0.00b 1.02s +51.00ms ⚠️
dist/legacy/index.html 775.00b +0.00b 1.15s +63.00ms ⚠️
dist/modern/index.html 715.00b +0.00b 1.15s +63.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 10.81s +180.00ms
Cached 533.00ms +25.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.20m -347.00ms
Cached 1.78s -73.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.b384b1e5.js 1.77mb -6.00b 🚀 20.89s +67.00ms
dist/index.cd89e659.js 694.61kb +0.00b 40.89s -14.61s 🚀
dist/editorView.ef355943.js 594.90kb +0.00b 40.89s -14.02s 🚀
dist/popup.f0cbde5b.js 209.65kb +0.00b 40.89s -14.01s 🚀
dist/index.9c74c269.js 145.42kb +0.00b 40.89s -14.61s 🚀
dist/Toolbar.dc4bc925.js 107.22kb +0.00b 40.89s -14.02s 🚀
dist/card.534068cb.js 62.65kb +0.00b 40.89s -14.61s 🚀
dist/Modal.edd1628e.js 45.31kb +0.00b 40.89s -14.02s 🚀
dist/js.0f0bb621.js 17.24kb +0.00b 40.89s -14.02s 🚀
dist/ui.8b651d39.js 14.93kb +0.00b 40.89s -14.02s 🚀
dist/smartMediaEditor.99448c62.js 13.24kb +0.00b 40.89s -14.02s 🚀
dist/dropzone.0d183115.js 12.13kb +0.00b 40.89s -14.02s 🚀
dist/card.45f850d6.js 5.75kb +0.00b 40.89s -14.61s 🚀
dist/EmojiPickerComponent.55e0a64c.js 3.71kb +0.00b 40.89s -14.02s 🚀
dist/png-chunks-extract.94b5b9fc.js 3.56kb +0.00b 40.89s -14.02s 🚀
dist/dropzone.cf53fd41.js 3.28kb +0.00b 40.89s -14.02s 🚀
dist/Modal.7f4c60b3.js 3.13kb +0.00b 40.89s -14.61s 🚀
dist/clipboard.41697175.js 2.92kb +0.00b 40.89s -14.02s 🚀
dist/ResourcedEmojiComponent.78f6ddfc.js 2.10kb +0.00b 40.89s -14.01s 🚀
dist/browser.09200cd5.js 1.68kb +0.00b 40.89s -14.02s 🚀
dist/media-card-analytics-error-boundary.75fac461.js 1.10kb +0.00b 40.89s -14.02s 🚀
dist/media-picker-analytics-error-boundary.cfe02cc6.js 949.00b +0.00b 40.89s -14.02s 🚀
dist/media-card-analytics-error-boundary.b1a780f3.js 945.00b +0.00b 40.89s -14.61s 🚀
dist/simpleHasher.2a6e12b6.js 626.00b +0.00b 40.89s -14.02s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.501698f8.js 1.77mb +1.00b ⚠️ 21.16s +259.00ms
dist/index.9da0070e.js 694.58kb +15.00b ⚠️ 56.11s +208.00ms
dist/editorView.bf5db572.js 594.90kb +0.00b 56.06s +14.57s ⚠️
dist/popup.f1a62e18.js 209.65kb +0.00b 56.06s +14.57s ⚠️
dist/Toolbar.6d2b95b8.js 107.22kb +0.00b 56.06s +14.57s ⚠️
dist/card.6fb92c7a.js 62.65kb +0.00b 56.06s +14.57s ⚠️
dist/Modal.d710cc03.js 45.31kb -15.00b 🚀 56.06s +14.57s ⚠️
dist/ui.12904806.js 14.93kb +0.00b 56.06s +14.57s ⚠️
dist/smartMediaEditor.f1ab6dbc.js 13.24kb +0.00b 56.06s +14.57s ⚠️
dist/dropzone.0d183115.js 12.13kb +0.00b 56.06s +14.57s ⚠️
dist/card.45f850d6.js 5.75kb +0.00b 56.06s +14.57s ⚠️
dist/EmojiPickerComponent.55e0a64c.js 3.71kb +0.00b 56.06s +14.57s ⚠️
dist/dropzone.a10cce43.js 3.28kb +0.00b 56.06s +14.57s ⚠️
dist/Modal.7f4c60b3.js 3.13kb +0.00b 56.06s +14.57s ⚠️
dist/clipboard.969d5ad7.js 2.92kb +0.00b 56.06s +14.57s ⚠️
dist/ResourcedEmojiComponent.78f6ddfc.js 2.10kb +0.00b 56.06s +14.57s ⚠️
dist/browser.09200cd5.js 1.68kb +0.00b 56.06s +14.57s ⚠️
dist/media-card-analytics-error-boundary.75fac461.js 1.10kb +0.00b 56.06s +14.57s ⚠️
dist/media-picker-analytics-error-boundary.cfe02cc6.js 949.00b +0.00b 56.06s +14.57s ⚠️
dist/media-card-analytics-error-boundary.596dbab3.js 945.00b +0.00b 56.06s +14.57s ⚠️
dist/simpleHasher.2a6e12b6.js 626.00b +0.00b 56.06s +14.57s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.71s -137.00ms
Cached 440.00ms +11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@@ -50,10 +50,6 @@ export default class BundleGraph<TBundle: IBundle>
implements IBundleGraph<TBundle> {
#graph: InternalBundleGraph;
#options: ParcelOptions;
// This is invoked as `this.#createBundle.call(null, ...)` below, as private
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@devongovett devongovett merged commit c08afa2 into v2 Aug 29, 2021
@devongovett devongovett deleted the flow-158 branch August 29, 2021 04:53
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (69 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 10, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 11, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* v2: (38 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
lettertwo added a commit that referenced this pull request Sep 13, 2021
* bdo/number-edgetypes: (70 commits)
  Use yarnpkg registry for all the things (#6908)
  Fix issue about loading configs from tsconfig.json (#6881)
  Add `@section` to Compressor type (#6885)
  Parcel API improvements (#6866)
  Use stream-browserify for polyfilling instead (#6863)
  Add support for compressor plugins (#6776)
  Support for inline style attributes and inline scripts in SVG (#6797)
  Bump less (#6852)
  Make sure (non-React) SVGs are in separate bundles (#6757)
  Add support for injecting manifest into service workers (#6798)
  Fix 'does not export default' error with scope hoisting and url/worklet pipeline (#6803)
  Remaining cargo clippy fixes (#6829)
  Lazily install sharp only when needed (#6816)
  More cargo clippy suggestions (#6811)
  Don't emit runtime manifest for inline child bundles (#6807)
  Apply suggestions from rust-clippy (#6256)
  Fix add directoryExists function to matchFiles call. (#6784)
  Upgrade to Flow 158 (#6763)
  Revert "added cio headers (#6404)" (#6789)
  Process CSS in SVGs (#6743)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants