Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more types of dependencies in SVG #6750

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Add support for more types of dependencies in SVG #6750

merged 4 commits into from
Aug 25, 2021

Conversation

devongovett
Copy link
Member

Adds support for more elements that support href and xlink:href, as well as presentational attributes that support function references (e.g. url(other.svg#foo)). Also supports external scripts. Currently type="module" scripts are not natively supported in SVG, but Parcel still supports that attribute to distinguish between source types. We always generate global script output for compatibility. Support for inline scripts can be handled separately once #6743 is merged.

cc. @thewilkybarkid

@height
Copy link

height bot commented Aug 22, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 22, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.05s -126.00ms 🚀
Cached 339.00ms +32.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.9c1188a7.js 1.54kb +0.00b 908.00ms -50.00ms 🚀
dist/legacy/index.17e28617.js 1.15kb +0.00b 908.00ms -50.00ms 🚀
dist/modern/index.c6061158.js 1.08kb +0.00b 908.00ms -50.00ms 🚀
dist/legacy/index.html 775.00b +0.00b 1.06s -58.00ms 🚀
dist/modern/index.html 715.00b +0.00b 1.06s -58.00ms 🚀
dist/legacy/index.5ba75694.css 77.00b +0.00b 1.18s -76.00ms 🚀
dist/modern/index.14235cd8.css 77.00b +0.00b 1.18s -75.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 10.13s +107.00ms
Cached 493.00ms +32.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.1e014c76.png 274.00b +0.00b 205.00ms -31.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.13m +1.18s
Cached 1.66s +54.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.35b3dfb4.js 1.77mb -2.00b 🚀 19.12s +192.00ms
dist/EmojiPickerComponent.5e6c01fb.js 146.66kb +0.00b 31.84s +11.35s ⚠️
dist/esm.3971e230.js 33.13kb +0.00b 31.84s +11.35s ⚠️
dist/DatePicker.9d4e1bc9.js 22.96kb +0.00b 31.84s +11.35s ⚠️
dist/js.0f0bb621.js 17.24kb +0.00b 51.52s +13.91s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.56kb +0.00b 51.52s +13.91s ⚠️
dist/feedback.e18b45f0.js 1.75kb +0.00b 31.84s +11.35s ⚠️
dist/workerHasher.567cfc57.js 1.62kb +0.00b 31.84s +11.35s ⚠️
dist/heading6.b3b946d1.js 1.49kb +0.00b 31.84s +11.35s ⚠️
dist/heading5.e617db66.js 1.37kb +0.00b 31.84s +11.35s ⚠️
dist/expand.1f17de7f.js 1.27kb +0.00b 31.84s +11.35s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.cd20c0b1.js 1.77mb -4.00b 🚀 20.77s +1.09s ⚠️
dist/index.be0ff90c.js 694.58kb +11.00b ⚠️ 53.49s +1.50s
dist/component.97e1afbf.js 37.33kb +0.00b 20.77s +1.09s ⚠️
dist/component.f7165057.js 24.93kb +0.00b 20.77s +1.09s ⚠️
dist/component.2de9ac3a.js 6.81kb +0.00b 20.54s +1.09s ⚠️
dist/16.7b42ca8a.js 2.33kb +0.00b 20.77s +1.09s ⚠️
dist/date.c0482a02.js 1.85kb +0.00b 20.77s +1.09s ⚠️
dist/16.f3960d82.js 1.72kb +0.00b 20.54s +1.09s ⚠️
dist/16.3aec39cf.js 1.66kb +0.00b 20.54s +1.09s ⚠️
dist/code.cd95a955.js 1.50kb +0.00b 20.77s +1.09s ⚠️
dist/16.332fbe28.js 1.37kb +0.00b 20.54s +1.09s ⚠️
dist/16.79a0250b.js 1.33kb +0.00b 20.54s +1.09s ⚠️
dist/16.a877725f.js 1.33kb +0.00b 20.54s +1.09s ⚠️
dist/16.0eecfc6b.js 1.30kb +0.00b 20.54s +1.09s ⚠️
dist/16.01994bf0.js 1.30kb +0.00b 20.54s +1.09s ⚠️
dist/16.00ba62db.js 1.27kb +0.00b 20.54s +1.09s ⚠️
dist/16.8e758d30.js 1.22kb +0.00b 20.54s +1.09s ⚠️
dist/16.0555a5c0.js 1.19kb +0.00b 20.54s +1.09s ⚠️
dist/16.b114a692.js 1.18kb +0.00b 20.54s +1.09s ⚠️
dist/16.e21a2218.js 1.18kb +0.00b 20.54s +1.09s ⚠️
dist/16.922eddd1.js 1.13kb +0.00b 20.54s +1.09s ⚠️
dist/16.e92739d9.js 1.13kb +0.00b 20.54s +1.09s ⚠️
dist/16.92a42544.js 1.12kb +0.00b 20.54s +1.09s ⚠️
dist/16.e5c3bc4c.js 1.12kb +0.00b 20.54s +1.09s ⚠️
dist/16.0358f7c7.js 1.12kb +0.00b 20.54s +1.09s ⚠️
dist/action.9e337641.js 1.12kb +0.00b 20.77s +1.09s ⚠️
dist/16.455c97fa.js 1.12kb +0.00b 20.54s +1.09s ⚠️
dist/component.edb11b95.js 1.11kb +0.00b 20.77s +1.09s ⚠️
dist/16.b221eda2.js 1.08kb +0.00b 20.54s +1.09s ⚠️
dist/16.cc9a820b.js 1.04kb +0.00b 20.54s +1.09s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.27s +177.00ms
Cached 386.00ms -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 0058a02 into v2 Aug 25, 2021
@devongovett devongovett deleted the svg-deps branch August 25, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants