-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify source content handling #6286
Simplify source content handling #6286
Conversation
|
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
…6288) * Remap diagnostics and other source locations using input source map * Fix flow * Ignore test in flow config * Move to util, apply in CSS transformer as well
Goes into #6238. Opened a separate PR for feedback. Basically removed
asset.getSourcesContent
and set the source content in core.Also I think we don't need to extract the source content from existing source maps because
map.extends
should handle copying over the correct source content from the original map. We only need to set the source content if there was no original map. Could be wrong though. Maybe we should add an integration test for this.