patch(hmr): use hostname for WS instantiation #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
approved these changes
Dec 28, 2017
|
Looks good, the tests are failing though. You'll need to shim |
|
Yeah, a bit hasty push on my part, will get that fixed and pushed. |
|
Tests passing, lmk if there's anything else needed. |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* patch(hmr): use hostname for WS instantiation * test(hmr): add hostname shim for testing * Move location shim somewhere common
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* patch(hmr): use hostname for WS instantiation * test(hmr): add hostname shim for testing * Move location shim somewhere common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #276 and removes hard-coded
localhostfor websockets to use thewindow.location.hostnameinstead, allowing users to run this on remote hosts or different domains.