-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing some tests that fail because of environment setups. #2590
Conversation
@@ -27,5 +27,14 @@ function jsonToError(json) { | |||
} | |||
} | |||
|
|||
function symlinkPrivilegeWarning() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should be part of utils.
We should probably make a utils package for testing Parcel and Parcel plugins somewhere in the future to prevent installing test specific utils to every users download of Parcel.
For now this is good enough though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you know, parcel-bundler/test/utils.js
and integration-tests/test/utils.js
are exactly same. Because of that, I wondered what to do.
Now I found the test-util
package. How about moving this to that package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea, didn't know there was a test-utils package already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question:
How about merging parcel-bundler/test/utils.js
and integration-tests/test/utils.js
to test-utils/utils.js
this time?
1/31 changes.
↪️ Pull Request
Sometimes, we cannot pass some tests because:
So, I changed these:
cmd
Admin article when symlink fails.💻 Examples
None
🚨 Test instructions
git clone https://github.com/parcel-bundler/parcel.git
on Windows 10.yarn test
✔️ PR Todo