Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default public-url to / #1040

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Change default public-url to / #1040

merged 1 commit into from
Mar 22, 2018

Conversation

devongovett
Copy link
Member

Now that this works correctly in the dev server as of #974, this should be a much more sensible default for both production and development builds. Fixes #714.

Now that this works correctly in the dev server as of #974, this should be a much more sensible default for both production and development builds. Fixes #714.
@codecov-io
Copy link

Codecov Report

Merging #1040 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   89.24%   88.99%   -0.25%     
==========================================
  Files          71       71              
  Lines        3683     3636      -47     
==========================================
- Hits         3287     3236      -51     
- Misses        396      400       +4
Impacted Files Coverage Δ
src/Bundler.js 89.96% <100%> (ø) ⬆️
src/utils/syncPromise.js 73.68% <0%> (-26.32%) ⬇️
src/assets/StylusAsset.js 70.88% <0%> (-10.13%) ⬇️
src/assets/ReasonAsset.js 91.66% <0%> (-8.34%) ⬇️
src/assets/LESSAsset.js 86.36% <0%> (-6.82%) ⬇️
src/assets/SASSAsset.js 85.1% <0%> (-6.39%) ⬇️
src/utils/config.js 86.95% <0%> (-1.45%) ⬇️
src/assets/YAMLAsset.js 100% <0%> (ø) ⬆️
src/assets/CoffeeScriptAsset.js 100% <0%> (ø) ⬆️
src/assets/TOMLAsset.js 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cab32...e24f42c. Read the comment docs.

@mightyiam
Copy link

Great!

@devongovett devongovett merged commit 3d704c6 into master Mar 22, 2018
@devongovett devongovett deleted the public-url branch March 22, 2018 16:36
patricksmith added a commit to patricksmith/parcel that referenced this pull request Aug 3, 2018
As of parcel-bundler#1040, the default value for `--public-url` is `/`, not the `--out-dir` option anymore.
DeMoorJasper pushed a commit that referenced this pull request Aug 3, 2018
Just a small documentation change -- as of #1040, the default value for `--public-url` is `/`, not the `--out-dir` option anymore.
devongovett added a commit that referenced this pull request Oct 15, 2018
Now that this works correctly in the dev server as of #974, this should be a much more sensible default for both production and development builds. Fixes #714.
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Just a small documentation change -- as of #1040, the default value for `--public-url` is `/`, not the `--out-dir` option anymore.
devongovett added a commit that referenced this pull request Oct 15, 2018
Now that this works correctly in the dev server as of #974, this should be a much more sensible default for both production and development builds. Fixes #714.
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Just a small documentation change -- as of #1040, the default value for `--public-url` is `/`, not the `--out-dir` option anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants