Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getConfig returns null for empty config file #7371

Closed
mischnic opened this issue Nov 27, 2021 · 0 comments · Fixed by #7418
Closed

getConfig returns null for empty config file #7371

mischnic opened this issue Nov 27, 2021 · 0 comments · Fixed by #7418

Comments

@mischnic
Copy link
Member

🐛 bug report

I found it very unexpected that config.getConfig[From] returns null (usually meaning that no config file could be found) if a config file was found.

Especially because there are config formats where an empty file is valid (yaml, toml).

🤔 Expected Behavior

Just parse the file, an empty json config file would throw a parse error (which would be fine/correct).

😯 Current Behavior

Null is returned

💁 Possible Solution

Remove this line

if (!configContent) return null;

🌍 Your Environment

Software Version(s)
Parcel b9426b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant