Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript not using semver, should peerDependencies be > instead of ^? #5978

Closed
fuxingloh opened this issue Mar 10, 2021 · 0 comments · Fixed by #6263
Closed

typescript not using semver, should peerDependencies be > instead of ^? #5978

fuxingloh opened this issue Mar 10, 2021 · 0 comments · Fixed by #6263

Comments

@fuxingloh
Copy link

fuxingloh commented Mar 10, 2021

🐛 bug report

With auto install, parcel attempts to download the typescript transformer this fails due to peer deps resolution. I use typescript 4.2.2 for my development, while peerDeps for the transformer package is set to ^3.0.0. This implies peer deps from 3.0.0 to 3.9.9, however typescript is not using semver and 4.0.0 is not a major release non a breaking change, so it should be >=3.0.0 instead?

Typescript is not using semver: microsoft/TypeScript#14116

"devDependencies": {
"typescript": "^3.0.0"
},
"peerDependencies": {
"typescript": "^3.0.0"
}

🎛 Configuration (.babelrc, package.json, cli command)

{
  "devDependencies": {
    "@defichain/testcontainers": "0.0.0",
    "parcel": "2.0.0-nightly.620",
    "typescript": "4.2.2"
  }
}

🤔 Expected Behavior

Auto install should install without throwing peerDependencies error as typescript is not using semver.

😯 Current Behavior

Auto install fail if there is a conflicting peerDependencies. (Meanwhile, I force install with npm i --force and use --no-autoinstall)

💁 Possible Solution

Maybe use >=3.0.0 instead for all typescript peerDeps?

🔦 Context

💻 Code Sample

🌍 Your Environment

Software Version(s)
Parcel 2.0.0-nightly.620
Node v14.15.0
npm/Yarn 7.5.6
Operating System MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants