kotlin test fails when Java is not configured or installed. #2603
Comments
sainthkh
added a commit
to sainthkh/parcel
that referenced
this issue
Jan 31, 2019
3 tasks
DeMoorJasper
pushed a commit
that referenced
this issue
Feb 3, 2019
#2605) * Ignore Kotlin tests and show messages when Java is not installed or configured. (#2603) * Skip symlink tests and show warning message when tests are run without admin privilege. (#2602) * Moved parcel-bundler/test/utils.js and integration-tests/test/utils.js into test-utils/src/utils.js. (#2604) * Fixed eslint errors. * Use the test to assert this.child.killed rather than checking time difference. (#2609) (#2612)
|
Hi! I just encountered this error on a fresh clone of the repo, on the Node: 11.9.0 (edited to include version numbers) |
|
@DeMoorJasper It seems that recent master merge regresses some test cases. |
|
@sainthkh I’ll have a look at the merge history in a couple hours |
|
@sainthkh Seems like the tests on master are fairly stable? |
|
Then, I'll check it and open a new PR. |
|
I ran tests and there was no problem with kotlin. Can you give us some error messages? |
|
@sainthkh after installing java on my machine, there were no kotlin or java related errors. I tried uninstalling java and running the tests again but wasn't able to reproduce my error. I wonder if only appears if the machine has never had java installed? (That was my case.) Unfortunately I didn't keep the logs of those failures, but one symptom was I would get a Mac OS popup prompting me to install java when I ran the tests. |
|
Then, we need to wait until someone else has the same problem. |
|
I'm having the same issue, but im also working on a PR regarding posthtml, so ignore the errors coming from there. Here are the errors I get: |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 bug report
It's really rare for developers' machine to not have Java. But sometimes it happens. (And actually, mine was one of that rare one.)
Note: It's the issue for #2590. I'm writing it here because I messed that PR up and started again from scratch.
I'll publish new PR soon.
🎛 Configuration (.babelrc, package.json, cli command)
None
🤔 Expected Behavior
Tests pass without any problem.
😯 Current Behavior
Tests fail and show
💁 Possible Solution
Install Java. Or add the java.exe path to environment variables.
🔦 Context
I wanted to contribute to Parcel. So, I forked and cloned the repo and ran test. But it failed. I think showing a message like rust is a better solution.
💻 Code Sample
None.
🌍 Your Environment
The text was updated successfully, but these errors were encountered: