Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-source-maps flag appears to be ignored during build in 1.10.1 #2079

Closed
dsinni opened this issue Sep 29, 2018 · 9 comments
Closed

--no-source-maps flag appears to be ignored during build in 1.10.1 #2079

dsinni opened this issue Sep 29, 2018 · 9 comments
Labels

Comments

@dsinni
Copy link

dsinni commented Sep 29, 2018

🐛 bug report

--no-source-maps flag appears to be ignored during build. This just started happening recently, so I'm assuming it started in either 1.10.0 or 1.10.1.

🎛 Configuration (.babelrc, package.json, cli command)

CLI via npm script:

"build": "parcel build src/index.html -d dist --no-source-maps",

🤔 Expected Behavior

No source maps.

😯 Current Behavior

Source maps.

🌍 Your Environment

Software Version(s)
Parcel 1.10.1
Node 10.10.0
npm/Yarn npm 6.3.0
Operating System Windows 10
@levrik
Copy link

levrik commented Oct 1, 2018

Also experiencing this issue.
It's notable that the source map gets created but not linked from the JS file.

@sami616
Copy link

sami616 commented Oct 2, 2018

Im also experiencing this 1.10.1.

@levrik
Copy link

levrik commented Oct 2, 2018

Somehow this issue just disappeared yesterday, not sure why.

@HosseinAgha
Copy link

It seems this issue happens in >=1.10.0

@DeMoorJasper
Copy link
Member

Fixed by #2089 ?

@shimmerjs
Copy link

I'm still seeing this behavior on 1.11.0

@mrcoles
Copy link

mrcoles commented Feb 22, 2019

I am still seeing this issue on parcel-bundler 1.11.0.

  1. If I build with source maps, then rm -r dist/ and build with --no-source-maps, then I still get source maps in dist/
  2. If I then rm -r .cache/ dist/ to remove both the cache and dist and build again with --no-source-maps, then I get it without source maps
./node_modules/.bin/parcel --version
1.11.0

@wawhal
Copy link

wawhal commented Feb 27, 2019

You must remove the .cache directory to make the flags work as expected. The flag policy seems to be flag-first.

@DeMoorJasper
Copy link
Member

Opened a new issue to track this further as we have a more specific view on why this is happening now.

Further discussion should be moved here: #2692

Thanks for the detailed reproduction steps @mrcoles

@parcel-bundler parcel-bundler locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants