Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HIR visitor #63

Open
DaniPopes opened this issue Oct 18, 2024 · 5 comments
Open

Implement HIR visitor #63

DaniPopes opened this issue Oct 18, 2024 · 5 comments
Labels
A-sema Area: semantic analysis C-enhancement Category: an issue proposing an enhancement or a PR with one E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. P-medium Medium priority

Comments

@DaniPopes
Copy link
Member

Describe the feature

Implement HIR visitor traits and functions using the visitor macro, similar to the AST ones.

The main difference here is that we need to recurse using the Hir struct, which means that there should be an extra fn hir(&self) -> Hir<> method to return it and that is used in the other methods to recurse.

Additional context

No response

@DaniPopes DaniPopes added C-enhancement Category: an issue proposing an enhancement or a PR with one P-medium Medium priority E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. A-sema Area: semantic analysis labels Oct 18, 2024
@DaniPopes DaniPopes mentioned this issue Oct 21, 2024
68 tasks
@mahmudsudo
Copy link
Contributor

hi, can i take on this ?

@mahmudsudo
Copy link
Contributor

Any update on this ?

@DaniPopes
Copy link
Member Author

Sure go ahead

@mahmudsudo
Copy link
Contributor

Ok on it

@gakonst
Copy link
Member

gakonst commented Nov 25, 2024

hey @mahmudsudo any update here? also would love for people to describe the solution they want to design before asking for taking it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sema Area: semantic analysis C-enhancement Category: an issue proposing an enhancement or a PR with one E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants