diff --git a/crates/tracing/Cargo.toml b/crates/tracing/Cargo.toml index b5bcfacd530..8cf83e138ca 100644 --- a/crates/tracing/Cargo.toml +++ b/crates/tracing/Cargo.toml @@ -26,8 +26,8 @@ tracing-logfmt.workspace = true clap = { workspace = true, features = ["derive"] } eyre.workspace = true rolling-file.workspace = true -url.workspace = true +url = { workspace = true, optional = true } [features] default = ["otlp"] -otlp = ["reth-tracing-otlp"] +otlp = ["reth-tracing-otlp", "dep:url"] diff --git a/crates/tracing/src/layers.rs b/crates/tracing/src/layers.rs index 44b2fff5995..385c4fac51d 100644 --- a/crates/tracing/src/layers.rs +++ b/crates/tracing/src/layers.rs @@ -6,10 +6,8 @@ use std::{ fmt, path::{Path, PathBuf}, }; -use tracing::level_filters::LevelFilter; use tracing_appender::non_blocking::WorkerGuard; use tracing_subscriber::{filter::Directive, EnvFilter, Layer, Registry}; -use url::Url; /// A worker guard returned by the file layer. /// @@ -131,14 +129,14 @@ impl Layers { pub fn with_span_layer( &mut self, service_name: String, - endpoint_exporter: Url, + endpoint_exporter: url::Url, level: tracing::Level, ) -> eyre::Result<()> { // Create the span provider let span_layer = span_layer(service_name, &endpoint_exporter) .map_err(|e| eyre::eyre!("Failed to build OTLP span exporter {}", e))? - .with_filter(LevelFilter::from_level(level)); + .with_filter(tracing::level_filters::LevelFilter::from_level(level)); self.add_layer(span_layer);