diff --git a/Makefile b/Makefile index 5dbe2191282..967ab32b1df 100644 --- a/Makefile +++ b/Makefile @@ -420,7 +420,7 @@ lint-typos: ensure-typos ensure-typos: @if ! command -v typos &> /dev/null; then \ - echo "typos not found. Please install it by running the command `cargo install typos-cli` or refer to the following link for more information: https://github.com/crate-ci/typos" \ + echo "typos not found. Please install it by running the command 'cargo install typos-cli' or refer to the following link for more information: https://github.com/crate-ci/typos"; \ exit 1; \ fi @@ -439,7 +439,7 @@ lint-toml: ensure-dprint ensure-dprint: @if ! command -v dprint &> /dev/null; then \ - echo "dprint not found. Please install it by running the command `cargo install --locked dprint` or refer to the following link for more information: https://github.com/dprint/dprint" \ + echo "dprint not found. Please install it by running the command 'cargo install --locked dprint' or refer to the following link for more information: https://github.com/dprint/dprint"; \ exit 1; \ fi diff --git a/crates/net/network-api/src/lib.rs b/crates/net/network-api/src/lib.rs index 58fe2c124e8..4c71f168608 100644 --- a/crates/net/network-api/src/lib.rs +++ b/crates/net/network-api/src/lib.rs @@ -192,7 +192,7 @@ pub trait Peers: PeersInfo { /// Disconnect an existing connection to the given peer using the provided reason fn disconnect_peer_with_reason(&self, peer: PeerId, reason: DisconnectReason); - /// Connect to the given peer. NOTE: if the maximum number out outbound sessions is reached, + /// Connect to the given peer. NOTE: if the maximum number of outbound sessions is reached, /// this won't do anything. See `reth_network::SessionManager::dial_outbound`. fn connect_peer(&self, peer: PeerId, tcp_addr: SocketAddr) { self.connect_peer_kind(peer, PeerKind::Static, tcp_addr, None) diff --git a/crates/net/p2p/src/bodies/response.rs b/crates/net/p2p/src/bodies/response.rs index 20287a4b450..772fe6cbbd3 100644 --- a/crates/net/p2p/src/bodies/response.rs +++ b/crates/net/p2p/src/bodies/response.rs @@ -22,7 +22,7 @@ where } } - /// Return the reference to the response header + /// Return the difficulty of the response header pub fn difficulty(&self) -> U256 { match self { Self::Full(block) => block.difficulty(), diff --git a/crates/optimism/chainspec/src/dev.rs b/crates/optimism/chainspec/src/dev.rs index 3778cd712a3..44faa5e17ea 100644 --- a/crates/optimism/chainspec/src/dev.rs +++ b/crates/optimism/chainspec/src/dev.rs @@ -27,7 +27,7 @@ pub static OP_DEV: LazyLock> = LazyLock::new(|| { paris_block_and_final_difficulty: Some((0, U256::from(0))), hardforks, base_fee_params: BaseFeeParamsKind::Constant(BaseFeeParams::ethereum()), - deposit_contract: None, // TODO: do we even have? + deposit_contract: None, ..Default::default() }, } diff --git a/crates/optimism/cli/src/commands/import_receipts.rs b/crates/optimism/cli/src/commands/import_receipts.rs index f6a2214b643..b155bbb9e3d 100644 --- a/crates/optimism/cli/src/commands/import_receipts.rs +++ b/crates/optimism/cli/src/commands/import_receipts.rs @@ -315,7 +315,6 @@ mod test { let db = TestStageDB::default(); init_genesis(&db.factory).unwrap(); - // todo: where does import command init receipts ? probably somewhere in pipeline let provider_factory = create_test_provider_factory_with_node_types::(OP_MAINNET.clone()); let ImportReceiptsResult { total_decoded_receipts, total_filtered_out_dup_txns } = diff --git a/crates/optimism/payload/src/builder.rs b/crates/optimism/payload/src/builder.rs index d511b17392f..2fb2500e901 100644 --- a/crates/optimism/payload/src/builder.rs +++ b/crates/optimism/payload/src/builder.rs @@ -729,7 +729,7 @@ where info.cumulative_gas_used += gas_used; info.cumulative_da_bytes_used += tx_da_size; - // update add to total fees + // update and add to total fees let miner_fee = tx .effective_tip_per_gas(base_fee) .expect("fee is always valid; execution succeeded"); diff --git a/crates/optimism/txpool/src/supervisor/client.rs b/crates/optimism/txpool/src/supervisor/client.rs index 4cc67685b59..b362fae2e10 100644 --- a/crates/optimism/txpool/src/supervisor/client.rs +++ b/crates/optimism/txpool/src/supervisor/client.rs @@ -28,7 +28,7 @@ use std::{ use tracing::trace; /// Supervisor hosted by op-labs -// TODO: This should be changes to actual supervisor url +// TODO: This should be changed to actual supervisor url pub const DEFAULT_SUPERVISOR_URL: &str = "http://localhost:1337/"; /// The default request timeout to use diff --git a/crates/stages/stages/src/stages/merkle.rs b/crates/stages/stages/src/stages/merkle.rs index 54fc5b2477c..00e1177ed02 100644 --- a/crates/stages/stages/src/stages/merkle.rs +++ b/crates/stages/stages/src/stages/merkle.rs @@ -50,7 +50,7 @@ pub const MERKLE_STAGE_DEFAULT_INCREMENTAL_THRESHOLD: u64 = 7_000; /// The merkle hashing stage uses input from /// [`AccountHashingStage`][crate::stages::AccountHashingStage] and -/// [`StorageHashingStage`][crate::stages::AccountHashingStage] to calculate intermediate hashes +/// [`StorageHashingStage`][crate::stages::StorageHashingStage] to calculate intermediate hashes /// and state roots. /// /// This stage should be run with the above two stages, otherwise it is a no-op. diff --git a/crates/storage/provider/src/providers/static_file/mod.rs b/crates/storage/provider/src/providers/static_file/mod.rs index 2bf9cf66f9c..97a8ea95433 100644 --- a/crates/storage/provider/src/providers/static_file/mod.rs +++ b/crates/storage/provider/src/providers/static_file/mod.rs @@ -74,7 +74,7 @@ mod tests { fn assert_eyre(got: T, expected: T, msg: &str) -> eyre::Result<()> { if got != expected { - eyre::bail!("{msg} | got: {got:?} expected: {expected:?})"); + eyre::bail!("{msg} | got: {got:?} expected: {expected:?}"); } Ok(()) }