Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following Qt good practices for "real" multiplatform support #467

Open
vltr opened this issue Jul 14, 2016 · 4 comments
Open

Following Qt good practices for "real" multiplatform support #467

vltr opened this issue Jul 14, 2016 · 4 comments

Comments

@vltr
Copy link

vltr commented Jul 14, 2016

Hello!

Sorry if the issue title sounds like a demand, it is not (I got the code running in my box already). Problem: when using a static call to register QML types - you can see it here - you are at the same time assuming this might work on most *nix around, but it's not a good practice if you follow Qt guidelines for plugins and/or registering QML types. QML types should not even be registered "automagically" in any app. Plugins works for that. Plugins work even with a fancy btchs like MSVC ... The plugin actually looks okay, but when including the .pri plus adding QPM_INIT to defines ... Well ...

I already had a good conversation about this issue with @benlau, the author of quickflux, for this same reason. You can see more info about how Qt works and what's behind the scenes (on other platforms, like Windows) that have a completely different memory architecture handling (which I'm not a fan, believe me), but it leaves us instructions on how to make QML work on most platforms, which lead me to another issue on quickflux. Related links are listed in the issue already.

The code I worked on is already on a fork of mine, but I hadn't passed all your contributing guidelines (yet) and there's a lot of things I left behind, so for now I'll not make a PR. When I have time and if it's your interest, I can sure contribute with a PR. You can also implement yourselves, I take no credit 😉

The result of keeping on the good practice:

screenshot from 2016-07-14 11-04-52

screenshot from 2016-07-14 11-17-00

Note: except for OPTIONS += roboto, not a single line of code changed to result both screenshots.

My best regards,
Richard.

PS: your effort and the resulting product with qml-material is absolutelly incredible!! 👍

@afendin
Copy link

afendin commented Jul 22, 2016

Good day sir, sorry for posting this but i don't know who can help me with this two issues. I tried to use qml-material both way, submodule and System-wide but nothing works except demo and i just can't do anything for 3 days with this stuff. Can you advice me something?

@vltr
Copy link
Author

vltr commented Nov 11, 2016

@AmirAfendin oh man, I'm so sorry. I have muted this issue because I think no one was interested, but I think I may be very late now. I'm really sorry.

@afendin
Copy link

afendin commented Nov 11, 2016

It's okay man, even better that noone answered me because i eventually found native Qt material stuff and was happy:D Thank you for paying attention, really appreciate this.

@vltr
Copy link
Author

vltr commented Nov 11, 2016

@AmirAfendin allright! I'm glad to hear you found a solution that suits you better 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants