Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IvyMessagesInterface send_request not working as expected #131

Open
rafael1193 opened this issue Oct 12, 2020 · 1 comment
Open

IvyMessagesInterface send_request not working as expected #131

rafael1193 opened this issue Oct 12, 2020 · 1 comment

Comments

@rafael1193
Copy link

The function IvyMessagesInterface.send_request is sending the agent name in the place of the message class.

A CONFIG request message is sent as IvyMessagesInterface 63240_1 CONFIG_REQ 200 instead of ground 63240_1 CONFIG_REQ 200

self.agent_name, new_id, request_message.name, request_message.payload_to_ivy_string()

should be replaced by

class_name, new_id, request_message.name, request_message.payload_to_ivy_string()

@gautierhattenberger
Copy link
Member

Actually, this is correct, if you compare to the ocaml lib, it is the sender (agent) name that is sent in first position:
https://github.com/paparazzi/pprzlink/blob/master/lib/v2.0/ocaml/pprzLink.ml#L814

The confusion is probably coming from the fact that the agent name of the server is "ground", but does not refer to the class name in fact.
https://github.com/paparazzi/paparazzi/blob/master/sw/ground_segment/tmtc/server.ml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants