Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript errors on import #8

Closed
Stevenlee731 opened this issue May 25, 2020 · 2 comments
Closed

Typescript errors on import #8

Stevenlee731 opened this issue May 25, 2020 · 2 comments
Labels
question 🤔 Further information is requested

Comments

@Stevenlee731
Copy link

Stevenlee731 commented May 25, 2020

Hi! I'm receiving compile errors when im importing Reparentable. This is on a fresh new Create React App with Typescript.

`TypeScript error in /Users/node_modules/react-reparenting/dist/types/core/addChild.d.ts(1,13):
'=' expected. TS1005

1 | import type { Fiber } from 'react-reconciler';
| ^
2 | /**
3 | * Add a child fiber in a parent fiber and return the index in which it is added.
4 | * The position can be chosen by providing a key (string) or by providing an index (number).`

Deleted the tsconfig file and everything started to work.

@Stevenlee731
Copy link
Author

updating typescript from "~3.7.2" to "^3.9.3" fixed the issue for me.

@paol-imi paol-imi added the question 🤔 Further information is requested label May 25, 2020
@brettinternet
Copy link

This is likely related to typescript-eslint/typescript-eslint#1436, however we might consider adding < 3.8 TypeScript support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question 🤔 Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants