Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game Events Error #19

Closed
CandyOates opened this issue Nov 19, 2016 · 1 comment
Closed

Game Events Error #19

CandyOates opened this issue Nov 19, 2016 · 1 comment
Labels

Comments

@CandyOates
Copy link

Hi zachpanz88,

This is a very nice API. However, I notice that in events.game_events you have an error which causes the bottom of the inning to save the values for the top of the inning.

    # loop through the bottom half
    bot = x.findall('bottom')[0]
    for y in bot.findall('atbat'):
        # top info
        botinfo = []
        # loop through the top half
        bot = x.findall('top')[0]
        for y in bot.findall('atbat'):
@panzarino panzarino added the bug label Nov 20, 2016
@panzarino
Copy link
Owner

Yes, I think I lazily copied and pasted code from the top of the inning but forgot to change some values. I will fix this very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants