Skip to content

Commit 8ee7f32

Browse files
committed
Fix broken game type and rename to tag
1 parent b11e90f commit 8ee7f32

File tree

1 file changed

+47
-5
lines changed

1 file changed

+47
-5
lines changed

mlbgame/game.py

+47-5
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def scoreboard(year, month, day, home=None, away=None):
2626
# check if teams match parameters
2727
if (home_name == home and home!=None) or (away_name == away and away!=None) or (away==None and home==None):
2828
# throw all the data into a complicated dictionary
29-
game_type = "go_game"
29+
game_tag = game.tag
3030
game_data = game.find('game')
3131
game_id = game_data.attrib['id']
3232
game_league = game_data.attrib['league']
@@ -43,7 +43,7 @@ def scoreboard(year, month, day, home=None, away=None):
4343
away_team_hits = int(away_team_data.attrib['H'])
4444
away_team_errors = int(away_team_data.attrib['E'])
4545
# check type of game
46-
if game.tag == "go_game" or game.tag == "ig_game":
46+
if game_tag == "go_game" or game_tag == "ig_game":
4747
try:
4848
w_pitcher_data = game.find('w_pitcher')
4949
w_pitcher = w_pitcher_data.find('pitcher').attrib['name']
@@ -69,9 +69,31 @@ def scoreboard(year, month, day, home=None, away=None):
6969
except:
7070
sv_pitcher = ""
7171
sv_pitcher_saves = 0
72-
output = {'game_id':game_id, 'game_type':game_type, 'game_league':game_league, 'game_status':game_status, 'game_start_time':game_start_time, 'home_team':home_team, 'home_team_runs': home_team_runs, 'home_team_hits': home_team_hits, 'home_team_errors': home_team_errors, 'away_team':away_team, 'away_team_runs': away_team_runs, 'away_team_hits': away_team_hits, 'away_team_errors': away_team_errors, 'w_pitcher':w_pitcher, 'w_pitcher_wins': w_pitcher_wins, 'w_pitcher_losses': w_pitcher_losses, 'l_pitcher':l_pitcher, 'l_pitcher_wins': l_pitcher_wins, 'l_pitcher_losses': l_pitcher_losses, 'sv_pitcher':sv_pitcher, 'sv_pitcher_saves': sv_pitcher_saves}
72+
output = {
73+
'game_id': game_id,
74+
'game_tag': game_tag,
75+
'game_league': game_league,
76+
'game_status': game_status,
77+
'game_start_time': game_start_time,
78+
'home_team': home_team,
79+
'home_team_runs': home_team_runs,
80+
'home_team_hits': home_team_hits,
81+
'home_team_errors': home_team_errors,
82+
'away_team': away_team,
83+
'away_team_runs': away_team_runs,
84+
'away_team_hits': away_team_hits,
85+
'away_team_errors': away_team_errors,
86+
'w_pitcher': w_pitcher,
87+
'w_pitcher_wins': w_pitcher_wins,
88+
'w_pitcher_losses': w_pitcher_losses,
89+
'l_pitcher': l_pitcher,
90+
'l_pitcher_wins': l_pitcher_wins,
91+
'l_pitcher_losses': l_pitcher_losses,
92+
'sv_pitcher': sv_pitcher,
93+
'sv_pitcher_saves': sv_pitcher_saves
94+
}
7395
# games that were not played
74-
elif game.tag == "sg_game":
96+
elif game_tag == "sg_game":
7597
try:
7698
p_pitcher_data = game.findall('p_pitcher')
7799
p_pitcher_home_data = p_pitcher_data[0]
@@ -89,7 +111,27 @@ def scoreboard(year, month, day, home=None, away=None):
89111
p_pitcher_away = ""
90112
p_pitcher_away_wins = 0
91113
p_pitcher_away_losses = 0
92-
output = {'game_id':game_id, 'game_type':game_type, 'game_league':game_league, 'game_status':game_status, 'game_start_time':game_start_time, 'home_team':home_team, 'home_team_runs': home_team_runs, 'home_team_hits': home_team_hits, 'home_team_errors': home_team_errors, 'away_team':away_team, 'away_team_runs': away_team_runs, 'away_team_hits': away_team_hits, 'away_team_errors': away_team_errors, 'p_pitcher_home':p_pitcher_home, 'p_pitcher_home_wins': p_pitcher_home_wins, 'p_pitcher_home_losses': p_pitcher_home_losses, 'p_pitcher_away':p_pitcher_away, 'p_pitcher_away_wins': p_pitcher_away_wins, 'p_pitcher_away_losses': p_pitcher_away_losses}
114+
output = {
115+
'game_id':game_id,
116+
'game_tag':game_tag,
117+
'game_league':game_league,
118+
'game_status':game_status,
119+
'game_start_time':game_start_time,
120+
'home_team':home_team,
121+
'home_team_runs': home_team_runs,
122+
'home_team_hits': home_team_hits,
123+
'home_team_errors': home_team_errors,
124+
'away_team':away_team,
125+
'away_team_runs': away_team_runs,
126+
'away_team_hits': away_team_hits,
127+
'away_team_errors': away_team_errors,
128+
'p_pitcher_home':p_pitcher_home,
129+
'p_pitcher_home_wins': p_pitcher_home_wins,
130+
'p_pitcher_home_losses': p_pitcher_home_losses,
131+
'p_pitcher_away':p_pitcher_away,
132+
'p_pitcher_away_wins': p_pitcher_away_wins,
133+
'p_pitcher_away_losses': p_pitcher_away_losses
134+
}
93135
# put this dictionary into the larger dictionary
94136
games[game_id]=output
95137
return games

0 commit comments

Comments
 (0)