Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "jku" header to JoseHeaderParameters #220

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Add "jku" header to JoseHeaderParameters #220

merged 2 commits into from
Jul 1, 2021

Conversation

ekosz
Copy link
Contributor

@ekosz ekosz commented Jun 30, 2021

RFC Link: https://datatracker.ietf.org/doc/html/rfc7515#section-4.1.2

@panva How are the docs generated? Do I do that in this PR? Or is that a separate process?

panva
panva requested changes Jun 30, 2021
View reviewed changes
Copy link
Owner

@panva panva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the docs generated? Do I do that in this PR? Or is that a separate process?

That's part of the release process on my end, just updating the types like you did is enough % the missing period.

src/types.d.ts Outdated Show resolved Hide resolved
@ekosz @panva
Add period
5e05bc7 
Co-authored-by: Filip Skokan <[email protected]>
@ekosz
Copy link
Contributor Author

ekosz commented Jun 30, 2021

Got it. Thank you

@ekosz ekosz requested a review from panva June 30, 2021 19:55
@panva panva merged commit 72a72db into panva:main Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@panva panva Awaiting requested review from panva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekosz @panva