From 6759bd7ef7b792f26391e70b6b40556020365e81 Mon Sep 17 00:00:00 2001
From: Tom Dyas <tdyas@toolchain.com>
Date: Sat, 15 Jan 2022 00:06:26 +0100
Subject: [PATCH] upgrade to Rust v1.58.0 (#14174)

Upgrade to Rust v1.58.0.

Changes:
- [Captured identifiers in format strings](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings)
- [More #[must_use] in the standard library](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#more-must_use-in-the-standard-library)
---
 .github/workflows/test-cron.yaml       | 4 ++--
 .github/workflows/test.yaml            | 6 +++---
 rust-toolchain                         | 2 +-
 src/rust/engine/async_value/src/lib.rs | 1 +
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/test-cron.yaml b/.github/workflows/test-cron.yaml
index 8c2f4a13aff..823635bf9c7 100644
--- a/.github/workflows/test-cron.yaml
+++ b/.github/workflows/test-cron.yaml
@@ -52,7 +52,7 @@ jobs:
       uses: actions/cache@v2
       with:
         key: ${{ runner.os }}-rustup-${{ hashFiles('rust-toolchain') }}
-        path: '~/.rustup/toolchains/1.57.0-*
+        path: '~/.rustup/toolchains/1.58.0-*
 
           ~/.rustup/update-hashes
 
@@ -203,7 +203,7 @@ jobs:
       uses: actions/cache@v2
       with:
         key: ${{ runner.os }}-rustup-${{ hashFiles('rust-toolchain') }}
-        path: '~/.rustup/toolchains/1.57.0-*
+        path: '~/.rustup/toolchains/1.58.0-*
 
           ~/.rustup/update-hashes
 
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 148814004cf..e44cbe005ca 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -52,7 +52,7 @@ jobs:
       uses: actions/cache@v2
       with:
         key: ${{ runner.os }}-rustup-${{ hashFiles('rust-toolchain') }}
-        path: '~/.rustup/toolchains/1.57.0-*
+        path: '~/.rustup/toolchains/1.58.0-*
 
           ~/.rustup/update-hashes
 
@@ -202,7 +202,7 @@ jobs:
       uses: actions/cache@v2
       with:
         key: ${{ runner.os }}-rustup-${{ hashFiles('rust-toolchain') }}
-        path: '~/.rustup/toolchains/1.57.0-*
+        path: '~/.rustup/toolchains/1.58.0-*
 
           ~/.rustup/update-hashes
 
@@ -399,7 +399,7 @@ jobs:
       uses: actions/cache@v2
       with:
         key: ${{ runner.os }}-rustup-${{ hashFiles('rust-toolchain') }}
-        path: '~/.rustup/toolchains/1.57.0-*
+        path: '~/.rustup/toolchains/1.58.0-*
 
           ~/.rustup/update-hashes
 
diff --git a/rust-toolchain b/rust-toolchain
index 5393d438e91..073944bbcb1 100644
--- a/rust-toolchain
+++ b/rust-toolchain
@@ -1,5 +1,5 @@
 [toolchain]
-channel = "1.57.0"
+channel = "1.58.0"
 components = [
   "cargo",
   "clippy",
diff --git a/src/rust/engine/async_value/src/lib.rs b/src/rust/engine/async_value/src/lib.rs
index c9b34132ca3..1133bdf0ddf 100644
--- a/src/rust/engine/async_value/src/lib.rs
+++ b/src/rust/engine/async_value/src/lib.rs
@@ -99,6 +99,7 @@ impl<T: Clone + Send + Sync + 'static> AsyncValueReceiver<T> {
         return Some(value.clone());
       }
 
+      #[allow(clippy::question_mark)]
       if item_receiver.changed().await.is_err() {
         return None;
       }