Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video metafields and asset_url warning #198

Open
ryanmcmanimie opened this issue Jan 12, 2025 · 1 comment
Open

Video metafields and asset_url warning #198

ryanmcmanimie opened this issue Jan 12, 2025 · 1 comment

Comments

@ryanmcmanimie
Copy link

When working with video type metafields I receive this warning:

"Use one of the asset_url filters to serve assets for better performance."

But these files don't live in the assets folder. Bug or incorrect implementation on my end?

<source
      src="{{ section.settings.mobile_video.sources[1].url }}". <!-- warning line
      media="(max-width: 768px)"
      type="video/mp4"
>
@ryanmcmanimie
Copy link
Author

ryanmcmanimie commented Jan 12, 2025

I suppose, in retrospect, just adding file_url would mute the warning although that's not really the correct usage since you're already passing a full url to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant