-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
DEPR: Series.first() and DataFrame.first() #53419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
8de4ffa
96ce115
ac7707a
75ee3b1
6cd46c8
b8e30b4
51e75fe
8fe71ff
e195758
148ddfd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9162,6 +9162,12 @@ def first(self, offset) -> Self: | |
| 3 days observed in the dataset, and therefore data for 2018-04-13 was | ||
| not returned. | ||
| """ | ||
| # GH45908 & GH#52487 | ||
| warnings.warn( | ||
| "first is deprecated and will be removed in a future version", | ||
|
||
| FutureWarning, | ||
| stacklevel=find_stack_level(), | ||
| ) | ||
| if not isinstance(self.index, DatetimeIndex): | ||
| raise TypeError("'first' only supports a DatetimeIndex index") | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,38 +10,43 @@ | |
| ) | ||
| import pandas._testing as tm | ||
|
|
||
| deprecated_msg = "first is deprecated" | ||
|
|
||
|
|
||
| class TestFirst: | ||
| def test_first_subset(self, frame_or_series): | ||
| ts = tm.makeTimeDataFrame(freq="12h") | ||
| ts = tm.get_obj(ts, frame_or_series) | ||
| result = ts.first("10d") | ||
| assert len(result) == 20 | ||
| with tm.assert_produces_warning(FutureWarning, match=deprecated_msg): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could we perhaps just do something like ts = tm.makeTimeDataFrame(freq="12h")
ts = tm.get_obj(ts, frame_or_series)
with tm.assert_produces_warning(FutureWarning, match=deprecated_msg):
result = ts.first("10d")
ts = tm.makeTimeDataFrame(freq="D")
ts = tm.get_obj(ts, frame_or_series)
with tm.assert_produces_warning(FutureWarning, match=deprecated_msg):
result = ts.first("10d")so that within each There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure 🫣 |
||
| result = ts.first("10d") | ||
|
|
||
| ts = tm.makeTimeDataFrame(freq="D") | ||
| ts = tm.get_obj(ts, frame_or_series) | ||
| result = ts.first("10d") | ||
| assert len(result) == 10 | ||
| assert len(result) == 20 | ||
|
|
||
| result = ts.first("3M") | ||
| expected = ts[:"3/31/2000"] | ||
| tm.assert_equal(result, expected) | ||
| ts = tm.makeTimeDataFrame(freq="D") | ||
| ts = tm.get_obj(ts, frame_or_series) | ||
| result = ts.first("10d") | ||
| assert len(result) == 10 | ||
|
|
||
| result = ts.first("21D") | ||
| expected = ts[:21] | ||
| tm.assert_equal(result, expected) | ||
| result = ts.first("3M") | ||
| expected = ts[:"3/31/2000"] | ||
| tm.assert_equal(result, expected) | ||
|
|
||
| result = ts[:0].first("3M") | ||
| tm.assert_equal(result, ts[:0]) | ||
| result = ts.first("21D") | ||
| expected = ts[:21] | ||
| tm.assert_equal(result, expected) | ||
|
|
||
| result = ts[:0].first("3M") | ||
| tm.assert_equal(result, ts[:0]) | ||
|
|
||
| def test_first_last_raises(self, frame_or_series): | ||
| # GH#20725 | ||
| obj = DataFrame([[1, 2, 3], [4, 5, 6]]) | ||
| obj = tm.get_obj(obj, frame_or_series) | ||
|
|
||
| msg = "'first' only supports a DatetimeIndex index" | ||
| with pytest.raises(TypeError, match=msg): # index is not a DatetimeIndex | ||
| obj.first("1D") | ||
| with tm.assert_produces_warning(FutureWarning, match=deprecated_msg): | ||
| with pytest.raises(TypeError, match=msg): # index is not a DatetimeIndex | ||
| obj.first("1D") | ||
|
||
|
|
||
| msg = "'last' only supports a DatetimeIndex index" | ||
| with pytest.raises(TypeError, match=msg): # index is not a DatetimeIndex | ||
|
|
@@ -73,25 +78,30 @@ def test_last_subset(self, frame_or_series): | |
| def test_first_with_first_day_last_of_month(self, frame_or_series, start, periods): | ||
| # GH#29623 | ||
| x = frame_or_series([1] * 100, index=bdate_range(start, periods=100)) | ||
| result = x.first("1M") | ||
| expected = frame_or_series( | ||
| [1] * periods, index=bdate_range(start, periods=periods) | ||
| ) | ||
| tm.assert_equal(result, expected) | ||
| with tm.assert_produces_warning(FutureWarning, match=deprecated_msg): | ||
| result = x.first("1M") | ||
| expected = frame_or_series( | ||
| [1] * periods, index=bdate_range(start, periods=periods) | ||
| ) | ||
| tm.assert_equal(result, expected) | ||
|
||
|
|
||
| def test_first_with_first_day_end_of_frq_n_greater_one(self, frame_or_series): | ||
| # GH#29623 | ||
| x = frame_or_series([1] * 100, index=bdate_range("2010-03-31", periods=100)) | ||
| result = x.first("2M") | ||
| expected = frame_or_series( | ||
| [1] * 23, index=bdate_range("2010-03-31", "2010-04-30") | ||
| ) | ||
| tm.assert_equal(result, expected) | ||
|
|
||
| @pytest.mark.parametrize("func", ["first", "last"]) | ||
| def test_empty_not_input(self, func): | ||
| with tm.assert_produces_warning(FutureWarning, match=deprecated_msg): | ||
| result = x.first("2M") | ||
| expected = frame_or_series( | ||
| [1] * 23, index=bdate_range("2010-03-31", "2010-04-30") | ||
| ) | ||
| tm.assert_equal(result, expected) | ||
|
|
||
| def test_empty_not_input(self): | ||
| # GH#51032 | ||
| df = DataFrame(index=pd.DatetimeIndex([])) | ||
| result = getattr(df, func)(offset=1) | ||
| result = getattr(df, "last")(offset=1) | ||
|
||
|
|
||
| with tm.assert_produces_warning(FutureWarning, match=deprecated_msg): | ||
| result = getattr(df, "first")(offset=1) | ||
|
|
||
| tm.assert_frame_equal(df, result) | ||
| assert df is not result | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the issue numbers here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks