Skip to content

TYP: misc return types #51912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 14, 2023
Merged

TYP: misc return types #51912

merged 6 commits into from
Mar 14, 2023

Conversation

@twoertwein
Copy link
Member

@twoertwein twoertwein commented Mar 11, 2023

xref #47521

Most changes are from renaming T to _<class>T.

MarcoGorelli
MarcoGorelli approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

topper-123
topper-123 reviewed Mar 12, 2023
View reviewed changes
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Mar 13, 2023
@topper-123
Copy link
Contributor

topper-123 commented Mar 13, 2023

typing_extensions has just been merged into main in #51480. So you can update this to use from _typing import Self instead of using typevar.

@mroeschke mroeschke added this to the 2.1 milestone Mar 14, 2023
@mroeschke mroeschke merged commit c9b560c into pandas-dev:main Mar 14, 2023
@mroeschke
Copy link
Member

mroeschke commented Mar 14, 2023

Thanks @twoertwein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topper-123 topper-123 topper-123 left review comments

@mroeschke mroeschke mroeschke approved these changes

+1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@twoertwein @topper-123 @mroeschke @MarcoGorelli