STYLE: Inconsistent namespace - Indexes (#39992) #40001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @alexprincel - no need for a whatsnewnote - other than that and the merge conflicts, this looks good, thanks |
alexprincel
force-pushed
the
style_cov_indexes
branch
2 times, most recently
from
336fce8 to
e3492a7
Compare
Member
|
Thanks @alexprincel for updating - there's still a conflict, could you resolve it please? |
Contributor
Author
Hello, yes will do. Could not finish yesterday but it's fixed on my local environment now. Still learning how to use git properly :) |
Member
|
No worries, I'd recommend the first 3 chapters of the Pro Git book to learn the common commands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't think tests apply here. By itself, does not close 39992.